Respect the port number from VoiceServerUpdate#285
Merged
GnomedDev merged 1 commit intoserenity-rs:currentfrom Jul 25, 2025
Merged
Respect the port number from VoiceServerUpdate#285GnomedDev merged 1 commit intoserenity-rs:currentfrom
GnomedDev merged 1 commit intoserenity-rs:currentfrom
Conversation
FelixMcFelix
approved these changes
Jul 25, 2025
Member
FelixMcFelix
left a comment
FelixMcFelix
left a comment
There was a problem hiding this comment.
Fair enough. This behaviour has been in since time immemorial at this point. The change makes sense, I think you just need to cargo +nightly fmt.
GnomedDev
force-pushed
the
remove-port-stripping
branch
from
0020676 to
ef06ae1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discord Staff have notified bot/library developers that they will be adding voice servers soon with port numbers other than the fixed port that has been used forever, and we need to respect this.
Although the code only stripped
80from the endpoint, let's get rid of all hard coding and just pass it in sensibly.