Skip to content

Improving duplicate menu item detection #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ofShard wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improving duplicate menu item detection #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "docpad-plugin-menu",
"description": "Automatically generates menu from documents folder",
"version": "2.1.0",
"version": "2.1.1",
"keywords": ["docpad", "docpad-plugin", "menu", "structure"],
"author": "Sergey Chikuyonok <serge.che@gmail.com> (http://chikuyonok.ru)",
"maintainers": [
Expand Down
11 changes: 7 additions & 4 deletions src/menu.plugin.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ class MenuItem
constructor: (@slug='', @document, @parent) ->
@children = []
@sortOrder = 0

if @parent?
parent.children.push @

Expand All @@ -42,9 +42,12 @@ class MenuItem

ctx = item

throw "Item duplicate: #{document.url}" if ctx.childBySlug slug

child = new MenuItem slug, document, ctx
if dupe = ctx.childBySlug slug
throw "Item duplicate: #{document.url}" if dupe.document
dupe.document = document
if document.menuOrder? then dupe.sortOrder = parseFloat document.menuOrder
else
child = new MenuItem slug, document, ctx

childBySlug: (slug) ->
_.find @children, (item) ->
Expand Down