fix: allow Clippy to push protected workflow files via fallback-to-issue#172
fix: allow Clippy to push protected workflow files via fallback-to-issue#172sergey-tihon merged 2 commits intomasterfrom
Conversation
…ranch in Clippy workflow Agent-Logs-Url: https://github.com/sergey-tihon/Clippit/sessions/98d2a173-18cd-4d37-9128-db7d81a56b45 Co-authored-by: sergey-tihon <1197905+sergey-tihon@users.noreply.github.com>
|
@copilot but it failed to push to https://github.com/sergey-tihon/Clippit/pull/168/changes that does not change workflow definition |
Right — PR #168 itself doesn't touch workflow files, but the 127 KB patch Clippy generated incidentally includes The |
There was a problem hiding this comment.
Pull request overview
Adjusts Clippy’s safe-output configuration so that when a run attempts to push changes that touch protected paths under .github/ (notably workflow files), it falls back to creating an issue instead of hard-failing—aligning push-to-pull-request-branch behavior with create-pull-request and resolving #171.
Changes:
- Add
protected-files: fallback-to-issueto thepush-to-pull-request-branchsafe-output config in.github/workflows/clippy.md. - Propagate
protected_files_policy: "fallback-to-issue"into thepush_to_pull_request_branchentry insideGH_AW_SAFE_OUTPUTS_HANDLER_CONFIGin.github/workflows/clippy.lock.yml.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/clippy.md | Enables fallback-to-issue for protected file changes when pushing to PR branches. |
| .github/workflows/clippy.lock.yml | Keeps the locked safe-outputs handler config in sync by adding the same protected-files fallback policy for push-to-PR-branch. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Closes #171
The Clippy workflow was hard-failing when pushing to PR branches that included changes to
.github/workflows/clippy.lock.ymlorclippy.md— both covered by the.github/protected path prefix — becausepush-to-pull-request-branchlacked aprotected_files_policy.Changes
clippy.md: Addedprotected-files: fallback-to-issueto thepush-to-pull-request-branchsafe-output config, matching the existing behavior oncreate-pull-requestclippy.lock.yml: Propagated"protected_files_policy":"fallback-to-issue"into thepush_to_pull_request_branchentry withinGH_AW_SAFE_OUTPUTS_HANDLER_CONFIG