Made findAndModify() callbacks use findAndModifyWriteOpResult#159
Open
Root-Core wants to merge 3 commits intosergeyksv:masterfrom
Open
Made findAndModify() callbacks use findAndModifyWriteOpResult#159Root-Core wants to merge 3 commits intosergeyksv:masterfrom
Root-Core wants to merge 3 commits intosergeyksv:masterfrom
Conversation
The mongodb-native-driver > 1.x does return an [findAndModifyWriteOpResult](http://mongodb.github.io/node-mongodb-native/3.0/api/Collection.html#~findAndModifyWriteOpResult) This change should mimic the behaviour of mongo-native-driver for `findAndModify()`.
…dAndModify # Conflicts: # lib/tcoll.js
Owner
|
Do you mind to make this behavior optional and depend on new option like
|
Owner
|
@Root-Core I'd rewrote your fix by making it configurable per my suggestion. Can you check please if your fine with this. See https://github.com/sergeyksv/tingodb/pull/170/files |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mongodb-native-driver > 1.x does return an findAndModifyWriteOpResult in the callback.
This change should mimic the behaviour of mongo-native-driver for
findAndModify().It makes Mongoose work correctly with the TingoDB in many cases.
I also adapted the tests, but I'm not too sure about these changes as the tests seem to not work under windows at all.