Fix some issues pointed out by Clippy in examples and tests#172
Merged
eldruin merged 1 commit intoserialport:mainfrom Mar 28, 2024
Merged
Fix some issues pointed out by Clippy in examples and tests#172eldruin merged 1 commit intoserialport:mainfrom
eldruin merged 1 commit intoserialport:mainfrom
Conversation
In case of writing data, the code looks like it expects all data to be written. And in case of reading data it expects some data to be read. Let's make this explicit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They surfaced in the CI builds for #168 and look like new catches from the latest Clippy as it is already present in main (https://github.com/serialport/serialport-rs/actions/runs/8470256382). The intentions in the examples an the test code look clears up the ambiguous parts in the code.