Open
Conversation
ced7de7 to
d4f2706
Compare
Author
|
CI is now green except for |
paolobarbolini
commented
Apr 30, 2025
60c3883 to
6560411
Compare
609d60c to
dd5d84b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With #176 stalled, I decided to try my hand at the
nixupgrade. This includes the v1.69 MSRV bump, which is required by the newernix, plus 1 upgrade commit for eachnixrelease. Tests pass on my Linux machine, and also when patching my program to use this branch.I've realized that there are probably more places where I could have replaced
RawFdwith a safer variant, but given that those are more refactors than strictly having to do with thenixupgrade, I'd like to do them in a separate followup PR.Closes #176
Fixes #175