Open
Conversation
Assuming that the `mach2` crate is updated to support these platforms, or we get rid of that dependency.
Required for `extern "C-unwind"`.
97 tasks
eldruin
reviewed
Oct 7, 2025
Contributor
eldruin
left a comment
There was a problem hiding this comment.
Thank you for this work and your work on the objc2 crates!
This sounds good to me.
FYI:
Yocto kirkstone (Rust 1.59.0) goes into EOL on April 2026.
The next supported release is Scathgap, which will have Rust 1.75.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
objc2-io-kitandobjc2-core-foundationinstead ofio-kit-sysandcore-foundation.These are part of the
objc2project which I maintain, which provides auto-generated bindings for Apple's APIs. This allows us to be much more confident that the bindings are correct, handles memory management likeCFRetain/CFReleaseautomatically, allows us to do cool things like embedding documentation from the headers.Note also that
core-foundationhas been soft-deprecated in favour ofobjc2-core-foundation, see servo/core-foundation-rs#729, so it makes sense to start this migration.This builds upon #260, so that should probably be merged first. This change also requires an MSRV bump to 1.71 because these crates use
extern "C-unwind", so this should probably be put in thev5.0.0milestone IIUC, see also #231.