Unhandled return values in TTYPort::open#322
Unhandled return values in TTYPort::open#322NONnonHere wants to merge 5 commits intoserialport:mainfrom
Conversation
This also includes harmonizing the nomenclature for our OwnedFd::into_raw which is called into_raw_fd in the standard library.
|
Thank you for preparing a PR @NONnonHere! And especially for also spotting that our I streamlined up some spacing and line breaks in the initial commit with Please ignore CI issues related to MSRV (which fail due to dependencies no longer supporting Rust 1.59.0) and cargo-semver-checks (which seems to have an issue with Rust 1.94.0 and works just fine with an older release). |
|
Thank you for updating the PR @NONnonHere! I found the changelog but there are also things puzzling me:
The module paths in After all the stuff I'm wondering about here, I'd like you to ask about some of the ideas and your workflow out of curiosity because I haven't seen such things in the past:
|
|
Hey @sirhcel, apologies for the inconvenience regarding the changelog. I pushed an automated update using claude agent as I was heading out and didn't give it the necessary review. |
@sirhcel Can you check this
Is it solving the TTYPort issue raised.