Open
Conversation
Pinning dependencies via Cargo.toml caused annoyance for many users building with up-to-date Rust versions as this affects the entire project being build and not just serialport. The build.yaml for GitHub Actions can serve as a guide on how to pin dependencies in your project if MSRV is an issue. The dependency libc was originally introduced just for pinning it as a sub-dependency but gets used in tests meanwhile.
Contributor
Author
|
The two failed link checks in CI are caused by not having these changes here landed yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we land #328, then the time has come for cutting a new release.