Skip to content

[WIP]: async support#331

Draft
onur-ozkan wants to merge 6 commits intoserialport:mainfrom
Orkavian:async-support
Draft

[WIP]: async support#331
onur-ozkan wants to merge 6 commits intoserialport:mainfrom
Orkavian:async-support

Conversation

@onur-ozkan
Copy link

TBF

@RossSmyth
Copy link
Contributor

While an interesting idea, I wonder if we can really do a better job than the mio-serial or tokio-serial

@onur-ozkan
Copy link
Author

While an interesting idea, I wonder if we can really do a better job than the mio-serial or tokio-serial

There is a discussion about this in the matrix channels.

@FrankenApps
Copy link

While an interesting idea, I wonder if we can really do a better job than the mio-serial or tokio-serial

Given the fact that both haven't had any commits for more than a year I would put more hope into this becoming a well-maintained alternative.

@RossSmyth
Copy link
Contributor

Ok, but it will require a good restructure for not-jank integration. Windows should be fairly straight-foward since it is all async internally. IDK how a "native" solution would look on Linux. epoll?

@onur-ozkan
Copy link
Author

Ok, but it will require a good restructure for not-jank integration. Windows should be fairly straight-foward since it is all async internally. IDK how a "native" solution would look on Linux. epoll?

Just to be clear, we are not doing junk integration. It's not going to be some randomly rushed work. And yes, native solution on linux means utilizing epoll, which is already being handled in this PR through async_io. There is no reason to handle raw async primitive for every OS, we can just use async_io which is fairly stable and reliable dependency for this purpose.

@onur-ozkan
Copy link
Author

While an interesting idea, I wonder if we can really do a better job than the mio-serial or tokio-serial

Given the fact that both haven't had any commits for more than a year I would put more hope into this becoming a well-maintained alternative.

That was one of the main reasons we talked about before we started this implementation.

@RossSmyth
Copy link
Contributor

I see, well that's good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants