Added blocking support for posix#50
Open
eranknafo2001 wants to merge 2 commits intoserialport:mainfrom
Open
Conversation
Open
Contributor
|
Thank you for this PR! What about some rewording on the proposed interface: As the I/O operations will always be blocking (in the sense of non-blocking I/O) wouldn't be This would be a breaking change. But couldn't a timeout type with an auto-conversion from set_blocking<T: Into<Option<Duration>>>(timeout: T) { ... }buy us out? And just as a side-note: Shouldn't be no timeout the default instead of 0? This would at least be my expectation as one who grew up on Linux. |
Contributor
Giving it a try at Rust Playground, it looks like it could. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12