Fixed issue #541 in README.md #577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Timestamp column is nullable by default but the README.md stated the opposite. This was fixed now.
|
Thanks, but why is the column actually nullable? How can there be a log line without a timestamp? |
|
That's a good question. It can probably be answered only by the initial developers of this sink (which was not me :)). Now it is like it is and changing it would maybe break existing applications using the MSSQL sink. I agree with you, that a log entry without a timestamp is not quite useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Timestamp column is nullable by default but the README.md stated the opposite. This was fixed now.