Always pass extra nix arguments to nix#368
Open
stuebinm wants to merge 2 commits intoserokell:masterfrom
Open
Conversation
Passing extra nix arguments given after the `--' to all other nix invocations allows using `deploy' for flakes projects, even on installations where flakes are not enabled globally, by simply passing deploy ... -- --extra-experimental-features flakes which did not work before and was arguably confusing behaviour.
This allows the deploy to function correctly on systems where nix-command is not an enabled experimental feature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing extra nix arguments given after the
--to all nixinvocations (even those that do not do builds) allows using
deployfor flakes projects, even oninstallations where flakes are not enabled globally, by simply passing
which did not work before: instead it the
test_flake_support()check would returnfalse, so we'd run the non-flake mode even if explicitly not desired. I'd argue is definitely confusing behaviour; in fact I found it during an introductory Nix session with someone running on a non-flake system, and was myself surprised it did not work.