Improve code of getExternalModules function

Author: emilien.escalle

lib/packExternalModules.js

@@ -153,28 +153,26 @@ function findExternalOrigin(issuer) {
 }
 
 function getExternalModules(stats) {
-  if (stats.compilation.chunks) {
-    const externals = new Set();
-    for (const chunk of stats.compilation.chunks) {
-      if (!chunk.modulesIterable) {
-        continue;
-      }
+  if (!stats.compilation.chunks) {
+    return [];
+  }
+  const externals = new Set();
+  for (const chunk of stats.compilation.chunks) {
+    if (!chunk.modulesIterable) {
+      continue;
+    }
 
-      // Explore each module within the chunk (built inputs):
-      for (const module of chunk.modulesIterable) {
-        if (isExternalModule(module)) {
-          externals.add({
-            origin: _.get(findExternalOrigin(module.issuer), 'rawRequest'),
-            external: getExternalModuleName(module)
-          });
-        }
+    // Explore each module within the chunk (built inputs):
+    for (const module of chunk.modulesIterable) {
+      if (isExternalModule(module)) {
+        externals.add({
+          origin: _.get(findExternalOrigin(module.issuer), 'rawRequest'),
+          external: getExternalModuleName(module)
+        });
       }
     }
-
-    return Array.from(externals);
   }
-
-  return [];
+  return Array.from(externals);
 }
 
 module.exports = {