[Fix #805] WorkflowDefinitionId should be public #806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjtirado
commented
Sep 23, 2025
Collaborator
Author
There was a problem hiding this comment.
Renamed to make explicit that this factory is not related with the definition id, but with the instance id
Signed-off-by: fjtirado <[email protected]>
fjtirado
commented
Sep 23, 2025
| static WorkflowId of(Document document) { | ||
| return new WorkflowId(document.getNamespace(), document.getName(), document.getVersion()); | ||
| } | ||
| public Map<WorkflowDefinitionId, WorkflowDefinition> workflowDefinitions() { |
Collaborator
Author
There was a problem hiding this comment.
Application can now be used as a workflow definition registry
fjtirado
commented
Sep 23, 2025
| document.getNamespace(), document.getName(), document.getVersion()); | ||
| } | ||
|
|
||
| public static WorkflowDefinitionId fromName(String name) { |
Collaborator
Author
There was a problem hiding this comment.
Useful as syntactic sugar in case you want to identify workflows with a single name.
If not use the record constructor to specify namespace and version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #805