Skip to content

ReadVersion0 method was too verbose #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2025
Merged

ReadVersion0 method was too verbose #882

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 6 additions & 12 deletions ...p/src/main/java/io/serverlessworkflow/impl/persistence/bigmap/BytesMapInstanceReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
import io.serverlessworkflow.impl.persistence.PersistenceTaskInfo;
import io.serverlessworkflow.impl.persistence.RetriedTaskInfo;
import java.io.ByteArrayInputStream;
import java.time.Instant;

public class BytesMapInstanceReader extends BigMapInstanceReader<byte[], byte[], byte[]> {

Expand Down Expand Up @@ -61,17 +60,12 @@ private PersistenceTaskInfo readVersion1(WorkflowInputBuffer buffer) {
}

private PersistenceTaskInfo readVersion0(WorkflowInputBuffer buffer) {
Instant date = buffer.readInstant();
WorkflowModel model = (WorkflowModel) buffer.readObject();
WorkflowModel context = (WorkflowModel) buffer.readObject();
Boolean isEndNode = null;
String nextPosition = null;
isEndNode = buffer.readBoolean();
boolean hasNext = buffer.readBoolean();
if (hasNext) {
nextPosition = buffer.readString();
}
return new CompletedTaskInfo(date, model, context, isEndNode, nextPosition);
return new CompletedTaskInfo(
buffer.readInstant(),
(WorkflowModel) buffer.readObject(),
(WorkflowModel) buffer.readObject(),
buffer.readBoolean(),
buffer.readBoolean() ? buffer.readString() : null);
}

@Override
Expand Down