Add RunTask.shell task

[mcruzdev]

Context

Implement RunTask.shell task:

document:
  dsl: '1.0.1'
  namespace: test
  name: run-shell-example
  version: '0.1.0'
do:
  - runShell:
      run:
        shell:
          command: 'echo "Hello, ${ .user.name }"'

Tracking

• Add arguments
• Implement await
• Implement return
• Support multiple OS
  

Closes #892

[mcruzdev]

@ricardozanini could you share with me a example of arguments? Should be something similar to:

document:
  dsl: '1.0.1'
  namespace: test
  name: run-shell-example
  version: '0.1.0'
do:
  - runShell:
      run:
        shell:
          command: 'kubectl'
          arguments:
            - 'apply'
            - '-f'
            - '/k8s'

And the output should be:

kubectl apply -f /k8s

I am assuming that arguments is a list.

[fjtirado]

@mcruzdev This has to wait to #899, then you can rebase and move forward

[fjtirado]

@mcruzdev I have merged #900, please rebase and continue from there, thanks

[mcruzdev]

Great @fjtirado, nice abstractions ;)

[ricardozanini]

@mcruzdev yes, the arguments are a list: https://github.com/serverlessworkflow/specification/blob/main/dsl-reference.md#shell-process

Which kind of example do you need?

[mcruzdev]

@mcruzdev yes, the arguments are a list: https://github.com/serverlessworkflow/specification/blob/main/dsl-reference.md#shell-process

Which kind of example do you need?

Ok, it is all, I think I do not need a example 😄

I had a confusion due to map as type of arguments in the documentation.

[ricardozanini]

@mcruzdev yes, the arguments are a list: https://github.com/serverlessworkflow/specification/blob/main/dsl-reference.md#shell-process
Which kind of example do you need?

Ok, it is all, I think I do not need a example 😄

I had a confusion due to map as type of arguments in the documentation.

You can do:

arguments:
  - key: value

Maybe in some use cases that would make sense.

[mcruzdev]

@mcruzdev yes, the arguments are a list: https://github.com/serverlessworkflow/specification/blob/main/dsl-reference.md#shell-process
Which kind of example do you need?

Ok, it is all, I think I do not need a example 😄
I had a confusion due to map as type of arguments in the documentation.

You can do:

arguments:
  - key: value

Maybe in some use cases that would make sense.

It is not clear to me again @ricardozanini, what is the real command statement in that case? The arguments will be used like an input (like script does)? Or we will have something like customcommand key=value or customcommand key=value in the statement.

[fjtirado]

Great work!
Just minor comments, except the error one.

[fjtirado]

@mcruzdev Another coupple of comments related with IOException handling

[ricardozanini]

@mcruzdev I think we already discussed in Slack, but since the spec expects a map we can have the following cases:

run:
        shell:
          command: 'echo "Hello"'
          attributes:
              - one
              - two
              - three

In this case, the resulting command would be echo "Hello" one two three.

Now, if we have:

run:
        shell:
          command: 'echo "Hello"'
          attributes:
              - key: one
              - key: two
              - key: three

The resulting command would be echo "Hello" key=one key=two key=three

Is that clear?

[mcruzdev]

@mcruzdev I think we already discussed in Slack, but since the spec expects a map we can have the following cases:

run:
        shell:
          command: 'echo "Hello"'
          attributes:
              - one
              - two
              - three

In this case, the resulting command would be echo "Hello" one two three.

Now, if we have:

run:
        shell:
          command: 'echo "Hello"'
          attributes:
              - key: one
              - key: two
              - key: three

The resulting command would be echo "Hello" key=one key=two key=three

Is that clear?

Hi @ricardozanini, I created a workflow document with the arguments being a list item as you mentioned above and I got a parsing error.

The only way to use arguments is the following:

• https://github.com/serverlessworkflow/sdk-java/pull/898/files#diff-463e0bcff57746562ad2405b321a25f5dcfc41f7580b6413911dac3c9c4f0a32
• https://github.com/serverlessworkflow/sdk-java/pull/898/files#diff-bd69063e51b60d727a3fc084512dad17c8507834166fda1947e468044230b53c
• https://github.com/serverlessworkflow/sdk-java/pull/898/files#diff-1b2333e624afa4b649dd7c16fd0c12c2177f366dbd948d3bfc6e054aa1b0bd62