Skip to content

[Fix #836] Implement beforeAgentInvocation and afterAgentInvocation f… #994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Fix #836] Implement beforeAgentInvocation and afterAgentInvocation f… #994

wants to merge 2 commits into from

Conversation

@treblereel
Copy link
Collaborator

@treblereel treblereel commented Nov 19, 2025

…or LC4J

#836 Implement beforeAgentInvocation and afterAgentInvocation for LC4J 1.6.0

@treblereel
[Fix serverlessworkflow#836] Implement beforeAgentInvocation and afte…
7b5ebfa 
…rAgentInvocation for LC4J

Signed-off-by: Dmitrii Tikhomirov <[email protected]>
@treblereel treblereel requested a review from fjtirado as a code owner November 19, 2025 01:13
@treblereel treblereel self-assigned this Nov 19, 2025
@treblereel treblereel added the java Pull requests that update java code label Nov 19, 2025
@treblereel treblereel added this to the 7.4.0 milestone Nov 19, 2025
ricardozanini
ricardozanini reviewed Nov 19, 2025
View reviewed changes
Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @treblereel but we also must adapt our implementation:

https://github.com/serverlessworkflow/sdk-java/blob/main/experimental/fluent/agentic-langchain4j/src/main/java/io/serverlessworkflow/fluent/agentic/langchain4j/ConditionalAgentServiceImpl.java#L53

It should be part of this PR. Basically, the missing before|afterAgentInvocation methods in our LC4J impl.

...ent/agentic/src/main/java/io/serverlessworkflow/fluent/agentic/AgentTaskItemListBuilder.java
private final AtomicReference<Consumer<AgenticScope>> beforeAgentInvocation =
new AtomicReference<>();
private final AtomicReference<Consumer<AgenticScope>> afterAgentInvocation =
new AtomicReference<>();
Copy link
Member

@ricardozanini ricardozanini Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why atomic? Is there a concurrency for changing these builders somewhere?

@ricardozanini ricardozanini removed this from the 7.4.0 milestone Nov 20, 2025
@treblereel
Copy link
Collaborator Author

treblereel commented Nov 20, 2025

Thanks, @treblereel but we also must adapt our implementation:

https://github.com/serverlessworkflow/sdk-java/blob/main/experimental/fluent/agentic-langchain4j/src/main/java/io/serverlessworkflow/fluent/agentic/langchain4j/ConditionalAgentServiceImpl.java#L53

It should be part of this PR. Basically, the missing before|afterAgentInvocation methods in our LC4J impl.

this one is tough ...

@ricardozanini
Copy link
Member

ricardozanini commented Nov 20, 2025

Thanks, @treblereel but we also must adapt our implementation:
https://github.com/serverlessworkflow/sdk-java/blob/main/experimental/fluent/agentic-langchain4j/src/main/java/io/serverlessworkflow/fluent/agentic/langchain4j/ConditionalAgentServiceImpl.java#L53
It should be part of this PR. Basically, the missing before|afterAgentInvocation methods in our LC4J impl.

this one is tough ...

I know! That was the real reason why I opened the issue. 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ricardozanini ricardozanini ricardozanini left review comments

@fjtirado fjtirado Awaiting requested review from fjtirado fjtirado is a code owner

Assignees

@treblereel treblereel

Labels

java Pull requests that update java code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@treblereel @ricardozanini