Skip to content

Minor format #995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2025
Merged

Minor format #995

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions .../main/java/io/serverlessworkflow/impl/executors/func/JavaContextFunctionCallExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
import io.serverlessworkflow.impl.WorkflowContext;
import io.serverlessworkflow.impl.WorkflowDefinition;
import io.serverlessworkflow.impl.WorkflowModel;
import io.serverlessworkflow.impl.WorkflowModelFactory;
import io.serverlessworkflow.impl.executors.CallableTask;
import java.util.Optional;
import java.util.concurrent.CompletableFuture;
Expand All @@ -31,7 +30,7 @@ public class JavaContextFunctionCallExecutor<T, V>
implements CallableTask<CallJava.CallJavaContextFunction<T, V>> {

private JavaContextFunction<T, V> function;
private Optional<Class<T>> inputClass = Optional.empty();
private Optional<Class<T>> inputClass;

@Override
public void init(CallJava.CallJavaContextFunction<T, V> task, WorkflowDefinition definition) {
Expand All @@ -42,10 +41,13 @@ public void init(CallJava.CallJavaContextFunction<T, V> task, WorkflowDefinition
@Override
public CompletableFuture<WorkflowModel> apply(
WorkflowContext workflowContext, TaskContext taskContext, WorkflowModel input) {
WorkflowModelFactory mf = workflowContext.definition().application().modelFactory();
T typedIn = JavaFuncUtils.convertT(input, inputClass);
V out = function.apply(typedIn, workflowContext);
return CompletableFuture.completedFuture(mf.fromAny(input, out));
return CompletableFuture.completedFuture(
workflowContext
.definition()
.application()
.modelFactory()
.fromAny(
input, function.apply(JavaFuncUtils.convertT(input, inputClass), workflowContext)));
}

@Override
Expand Down
16 changes: 10 additions & 6 deletions ...c/main/java/io/serverlessworkflow/impl/executors/func/JavaFilterFunctionCallExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
import io.serverlessworkflow.impl.WorkflowContext;
import io.serverlessworkflow.impl.WorkflowDefinition;
import io.serverlessworkflow.impl.WorkflowModel;
import io.serverlessworkflow.impl.WorkflowModelFactory;
import io.serverlessworkflow.impl.executors.CallableTask;
import java.util.Optional;
import java.util.concurrent.CompletableFuture;
Expand All @@ -31,7 +30,7 @@ public class JavaFilterFunctionCallExecutor<T, V>
implements CallableTask<CallJava.CallJavaFilterFunction<T, V>> {

private JavaFilterFunction<T, V> function;
private Optional<Class<T>> inputClass = Optional.empty();
private Optional<Class<T>> inputClass;

@Override
public void init(CallJava.CallJavaFilterFunction<T, V> task, WorkflowDefinition definition) {
Expand All @@ -42,10 +41,15 @@ public void init(CallJava.CallJavaFilterFunction<T, V> task, WorkflowDefinition
@Override
public CompletableFuture<WorkflowModel> apply(
WorkflowContext workflowContext, TaskContext taskContext, WorkflowModel input) {
WorkflowModelFactory mf = workflowContext.definition().application().modelFactory();
T typedIn = JavaFuncUtils.convertT(input, inputClass);
V out = function.apply(typedIn, workflowContext, taskContext);
return CompletableFuture.completedFuture(mf.fromAny(input, out));
return CompletableFuture.completedFuture(
workflowContext
.definition()
.application()
.modelFactory()
.fromAny(
input,
function.apply(
JavaFuncUtils.convertT(input, inputClass), workflowContext, taskContext)));
}

@Override
Expand Down
12 changes: 5 additions & 7 deletions ...bda/src/main/java/io/serverlessworkflow/impl/executors/func/JavaFunctionCallExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
import io.serverlessworkflow.impl.WorkflowContext;
import io.serverlessworkflow.impl.WorkflowDefinition;
import io.serverlessworkflow.impl.WorkflowModel;
import io.serverlessworkflow.impl.WorkflowModelFactory;
import io.serverlessworkflow.impl.executors.CallableTask;
import java.util.Optional;
import java.util.concurrent.CompletableFuture;
Expand All @@ -33,10 +32,6 @@ public class JavaFunctionCallExecutor<T, V>
private Function<T, V> function;
private Optional<Class<T>> inputClass;

static String fromInt(Integer integer) {
return Integer.toString(integer);
}

public void init(CallJava.CallJavaFunction<T, V> task, WorkflowDefinition definition) {
function = task.function();
inputClass = task.inputClass();
Expand All @@ -45,9 +40,12 @@ public void init(CallJava.CallJavaFunction<T, V> task, WorkflowDefinition defini
@Override
public CompletableFuture<WorkflowModel> apply(
WorkflowContext workflowContext, TaskContext taskContext, WorkflowModel input) {
WorkflowModelFactory modelFactory = workflowContext.definition().application().modelFactory();
return CompletableFuture.completedFuture(
modelFactory.fromAny(input, function.apply(JavaFuncUtils.convertT(input, inputClass))));
workflowContext
.definition()
.application()
.modelFactory()
.fromAny(input, function.apply(JavaFuncUtils.convertT(input, inputClass))));
}

@Override
Expand Down