Skip to content

Conversation

oEscal
Copy link
Contributor

@oEscal oEscal commented Jul 1, 2025

This PR adds multiple bug fixes for the feature implemented in #30:

  • The initial state of the state machine was obtained as the first state listed in the workflow. This was because the code in the TypeScript SDK was implemented in this manner. Now, the code checks for the start state.
  • Whenever a parallel state was the first one in the workflow, the state machine generator would throw an error. This was because the code was not creating the state in that specific case.

@oEscal
Copy link
Contributor Author

oEscal commented Jul 1, 2025

@cdavernas I am very sorry for these late changes, but I am detecting these bugs as I am testing weirder things using the SDK.

@cdavernas
Copy link
Member

@oEscal Come on, no worries! Thanks for your awesome contributions!

Copy link
Member

@cdavernas cdavernas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Cheers ❤️

@cdavernas cdavernas merged commit fd4379f into serverlessworkflow:main Jul 2, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants