refactor: update test file to use .each

Signed-off-by: Matthias Pichler <[email protected]>

Author: matthias-pichler

.ci/validation/src/index.test.ts

@@ -23,25 +23,27 @@ SWSchemaValidator.prepareSchemas();
 const examplePath = "../../../examples";
 
 describe(`Verify every example in the repository`, () => {
-  fs.readdirSync(path.join(__dirname, examplePath), {
-    encoding: SWSchemaValidator.defaultEncoding,
-    recursive: false,
-    withFileTypes: true,
-  }).forEach((file) => {
-    if (file.isFile() && file.name.endsWith(".yaml")) {
-      test(`Example ${file.name}`, () => {
-        const workflow = SWSchemaValidator.toJSON(
-          path.join(__dirname, `${examplePath}/${file.name}`)
-        );
-        const results = SWSchemaValidator.validateSchema(workflow);
-        if (results?.errors != null) {
-          console.warn(
-            `Schema validation on ${file.name} failed with: `,
-            JSON.stringify(results.errors, null, 2)
-          );
-        }
-        expect(results?.valid).toBeTruthy();
-      });
+  const examples = fs
+    .readdirSync(path.join(__dirname, examplePath), {
+      encoding: SWSchemaValidator.defaultEncoding,
+      recursive: false,
+      withFileTypes: true,
+    })
+    .filter((file) => file.isFile())
+    .filter((file) => file.name.endsWith(".yaml"))
+    .map((file) => file.name);
+
+  test.each(examples)("Example %s", (file) => {
+    const workflow = SWSchemaValidator.toJSON(
+      path.join(__dirname, `${examplePath}/${file}`)
+    );
+    const results = SWSchemaValidator.validateSchema(workflow);
+    if (results?.errors != null) {
+      console.warn(
+        `Schema validation on ${file} failed with: `,
+        JSON.stringify(results.errors, null, 2)
+      );
     }
+    expect(results?.valid).toBeTruthy();
   });
 });

.ci/validation/src/index.ts

@@ -30,15 +30,17 @@ export module SWSchemaValidator {
   export const defaultEncoding = "utf-8";
 
   export function prepareSchemas() {
-    fs.readdirSync(path.join(__dirname, schemaPath), {
+    const files = fs.readdirSync(path.join(__dirname, schemaPath), {
       encoding: defaultEncoding,
       recursive: false,
       withFileTypes: true,
-    }).forEach((file) => {
-      if (file.isFile()) {
-        ajv.addSchema(syncReadSchema(file.name));
-      }
     });
+
+    files
+      .filter((file) => file.isFile())
+      .forEach((file) => {
+        ajv.addSchema(syncReadSchema(file.name));
+      });
   }
 
   function syncReadSchema(filename: string): any {
@@ -54,14 +56,16 @@ export module SWSchemaValidator {
 
   export function validateSchema(workflow: Record<string, unknown>) {
     const validate = ajv.getSchema(workflowSchemaId);
-    if (validate) {
-      const isValid = validate(workflow);
-      return {
-        valid: isValid,
-        errors: validate.errors,
-      };
+
+    if (!validate) {
+      throw new Error(`Failed to validate schema on workflow`);
     }
-    throw new Error(`Failed to validate schema on workflow`);
+
+    const isValid = validate(workflow);
+    return {
+      valid: isValid,
+      errors: validate.errors,
+    };
   }
 }