Merge pull request #386 from serverlessworkflow/fix-operator-spec

cdavernas · web-flow · commit 7bd32f0c72e2 · 2024-09-05T10:01:50.000+02:00
Fix the Operator's RunnerDefinition by making its `Certificates` property optional
diff --git a/src/core/Synapse.Core/Resources/RunnerDefinition.cs b/src/core/Synapse.Core/Resources/RunnerDefinition.cs
@@ -43,8 +43,7 @@ public record RunnerDefinition
     /// <summary>
     /// Gets/sets the endpoint that references the base address and authentication policy for the Synapse API used by runners
     /// </summary>
-    [Required]
     [DataMember(Order = 3, Name = "certificates"), JsonPropertyOrder(3), JsonPropertyName("certificates"), YamlMember(Order = 3, Alias = "certificates")]
-    public virtual CertificateValidationStrategyDefinition Certificates { get; set; } = null!;
+    public virtual CertificateValidationStrategyDefinition? Certificates { get; set; }
     
 }

Original file line number	Diff line number	Diff line change
`@@ -43,8 +43,7 @@ public record RunnerDefinition`
`43`	`43`	`/// <summary>`
`44`	`44`	`/// Gets/sets the endpoint that references the base address and authentication policy for the Synapse API used by runners`
`45`	`45`	`/// </summary>`
`46`		`- [Required]`
`47`	`46`	`[DataMember(Order = 3, Name = "certificates"), JsonPropertyOrder(3), JsonPropertyName("certificates"), YamlMember(Order = 3, Alias = "certificates")]`
`48`		`- public virtual CertificateValidationStrategyDefinition Certificates { get; set; } = null!;`
	`47`	`+ public virtual CertificateValidationStrategyDefinition? Certificates { get; set; }`
`49`	`48`
`50`	`49`	`}`