Skip to content

Preserve endpoint field by converting JSON to YAML in create/edit view of the Dashboard #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2025
Merged

Preserve endpoint field by converting JSON to YAML in create/edit view of the Dashboard #541

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/dashboard/Synapse.Dashboard/Pages/Workflows/Create/Store.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
/// <summary>
/// Gets the service used to interact with the Synapse API
/// </summary>
protected ISynapseApiClient Api { get; } = api;

Check warning on line 68 in src/dashboard/Synapse.Dashboard/Pages/Workflows/Create/Store.cs

View workflow job for this annotation

GitHub Actions / build (9.0.x) 

Parameter 'ISynapseApiClient api' is captured into the state of the enclosing type and its value is also used to initialize a field, property, or event.

Check warning on line 68 in src/dashboard/Synapse.Dashboard/Pages/Workflows/Create/Store.cs

View workflow job for this annotation

GitHub Actions / build (9.0.x) 

Parameter 'ISynapseApiClient api' is captured into the state of the enclosing type and its value is also used to initialize a field, property, or event.

/// <summary>
/// Gets the service used to help handling Monaco editors
Expand Down Expand Up @@ -698,9 +698,8 @@
string document = "";
if (definition != null)
{
document = MonacoEditorHelper.PreferredLanguage == PreferredLanguage.JSON ?
JsonSerializer.SerializeToText(definition) :
YamlSerializer.SerializeToText(definition);
document = JsonSerializer.SerializeToText(definition);
if (MonacoEditorHelper.PreferredLanguage == PreferredLanguage.YAML) document = YamlSerializer.ConvertFromJson(document);
}
Reduce(state => state with
{
Expand Down