Fix use-after-free issues in Core Foundation object management #741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed some potential use-after-free bugs identified by static analysis in the core-text crate. The issues were caused by improper lifetime management of Core Foundation objects where raw pointers were being used after the underlying objects were dropped. Specifically:
In CTFontDescriptor::traits(): Eliminated intermediate CFType wrapper that was being dropped before the dictionary was returned
In create_font_descriptor() functions: Ensured CFData objects remain alive during C function calls by restructuring the unsafe block
These changes maintain the same API while ensuring memory safety through proper Core Foundation reference counting.