fix icu_capi version #606
Merged
fix icu_capi version #606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The vendored version of icu_capi was bumped to 1.5.0 in the SM 137 update, so we need to update the version in the Cargo.toml too. Additionally, we use `=1.5.0` to force selecting the same version as the vendored one. The vendored icu_capi is never built, only its headers are used. Signed-off-by: Jonathan Schwender <[email protected]>
|
#596 presumably is blocked until we get the integrity test back, but I think this change can be merged earlier. |
sagudev
approved these changes
Aug 8, 2025
Signed-off-by: Jonathan Schwender <[email protected]>
github-merge-queue bot
pushed a commit
to servo/servo
that referenced
this pull request
Aug 8, 2025
This bump downgrades icu_capi to 1.5.0, to match the version vendored in spidermonkey. Previous mozjs PRs: - servo/mozjs#606 - servo/mozjs#605 Testing: Covered by existing tests --------- Signed-off-by: Jonathan Schwender <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vendored version of icu_capi was bumped to 1.5.0 in the SM 137
update, so we need to update the version in the Cargo.toml too.
Additionally, we use
=1.5.0to force selecting the same version as the vendored one.The vendored icu_capi is never built, only its headers are used.