Fix mismatched_lifetime_syntaxes warning #656
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagudev
reviewed
Nov 12, 2025
mozjs/src/gc/collections.rs
Outdated
| T: GCMethods + Copy, | ||
| { | ||
| pub fn handle(&self) -> Handle<T> { | ||
| pub fn handle(&self) -> Handle<'_, T> { |
Member
There was a problem hiding this comment.
Shouldn't all lifetimes be explicit by lint?
Suggested change
| pub fn handle(&self) -> Handle<'_, T> { | |
| pub fn handle(&'_ self) -> Handle<'_, T> { |
sagudev
approved these changes
Nov 12, 2025
Member
sagudev
left a comment
sagudev
left a comment
There was a problem hiding this comment.
LGTM, although I prefer explicit lifetimes (even if '_). everywhere.
Signed-off-by: Jonathan Schwender <[email protected]>
Signed-off-by: Jonathan Schwender <[email protected]>
jschwe
force-pushed
the
compiler_warnings
branch
from
bd7e2cb to
8300852
Compare
jschwe
commented
Nov 18, 2025
| } | ||
|
|
||
| pub fn handle_mut(&mut self) -> MutableHandle<T> { | ||
| pub fn handle_mut(&'a mut self) -> MutableHandle<'a, T> { |
Member
Author
There was a problem hiding this comment.
Hmm, this seems to cause borrow-checker errors. The lifetime 'ashould be correct, given that handle() also uses it?
I don't have time to look deeper into this today though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #652
Not sure if this fixes all instances, since there are still many bindgen related warnings polluting the output, where I can't seem to find the option that can silence them.