SES-4388 : Auto scrolling issues #1521
Open
+32
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SES-4388
Fixes based on the issues found here.
This PR changes how insets and heights are set for the spacer. The changes here removes double applied space for lower android versions (tested on Android 9) while retaining its behavior for newer versions.
This also includes a
fastScrollflag forhandleScrollToBottomsince it might take a while to scroll to the bottom when sending attachments if the user is scrolled all the way up and it might mess with theisNearBottomflag.moveToMessagePositionwas also modified here to respect scrolling to the bottom. This fixes an issue where sending long messages does not scroll fully to the bottom since the default anchors it to the top of the bubble.