Merged
Conversation
Session 1.17.12
Session 1.17.13
…ower-idle-inhibitor fix: do not attempt on windows to lock twice the app suspension
There was a problem hiding this comment.
Pull request overview
Adds a new “donation appeal” session CTA variant and updates modal behavior to better control close affordances for that appeal.
Changes:
- Introduces
CTAVariant.DONATE_APPEALand switches the triggered donate CTA to use it. - Adds a no-warning URL open helper and refactors URL open/copy handling for interaction tracking.
- Extends
SessionWrapperModal/SessionFocusTrapwith new close/outside-click controls and adds a floating close button option.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| ts/localization | Updates localization submodule, presumably adding tokens/assets for the new donation appeal CTA. |
| ts/components/dialog/cta/types.ts | Adds the DONATE_APPEAL CTA variant enum value. |
| ts/components/dialog/SessionCTA.tsx | Implements the new donate appeal CTA rendering/behavior, including button logic and modal close behavior. |
| ts/components/dialog/OpenUrlModal.tsx | Refactors open/copy into helpers and exports openUrlNoDialog for direct URL opening. |
| ts/components/SessionWrapperModal.tsx | Adds props to control outside-click deactivation and a floating close button. |
| ts/components/SessionFocusTrap.tsx | Adds support for clickOutsideDeactivates to the focus trap configuration. |
Comments suppressed due to low confidence (2)
ts/components/SessionFocusTrap.tsx:1
SessionFocusTrapnow supportsclickOutsideDeactivates, butSessionWrapperModalintroduces a similarly named prop and (per the provided context) still doesn’t pass it through. This can lead to inconsistent outside-click behavior between the wrapper’sonMouseDownhandler and the focus trap’s behavior. Consider wiringclickOutsideDeactivates(and potentiallyallowOutsideClick) throughSessionWrapperModaltoSessionFocusTrapso the modal’s outside-click policy is controlled in one place.
import { FocusTrap, type FocusTrapProps } from 'focus-trap-react';
ts/components/SessionFocusTrap.tsx:1
SessionFocusTrapnow supportsclickOutsideDeactivates, butSessionWrapperModalintroduces a similarly named prop and (per the provided context) still doesn’t pass it through. This can lead to inconsistent outside-click behavior between the wrapper’sonMouseDownhandler and the focus trap’s behavior. Consider wiringclickOutsideDeactivates(and potentiallyallowOutsideClick) throughSessionWrapperModaltoSessionFocusTrapso the modal’s outside-click policy is controlled in one place.
import { FocusTrap, type FocusTrapProps } from 'focus-trap-react';
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Bilb
previously approved these changes
Mar 19, 2026
Bilb
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.