macOS ARM64 support#96
Merged
Bilb merged 107 commits intosession-foundation:devfrom Mar 31, 2025
yougotwill:feat/ses-2661/macos_arm64
Merged
macOS ARM64 support#96Bilb merged 107 commits intosession-foundation:devfrom yougotwill:feat/ses-2661/macos_arm64
Bilb merged 107 commits intosession-foundation:devfrom
yougotwill:feat/ses-2661/macos_arm64
Conversation
it is saved to the items table and requires an app restart
… the file server we now use blindVersionSignRequest
makes it easier to debug
log version comparison when debugging
branch name example release/1.14.6-alpha.0
… channel this allows us to access it on the node side in the auto update
changed some console.error to use logger.error
…nfig in the hopes it means it will detect our preleases
…not on the latest channel currently only supports alpha
improved some log messages
there is a known issue with electron updater quit and install
use URLSearchParams instead of string concatenation
… forceUpdate as parameters
so we use x64 instead of x86_64 for intel builds
… variables env variables are not shared with custom actions
…ctron builder added some logging for the steps
…osite action inputs fix check for mac certifcate before publishing
we need the exports of CSC_LINK and CSC_KEY_PASSWORD
we dont rely on uname anymore which would return x86_64 which isn't compatible with electron builder
Bilb
approved these changes
Mar 25, 2025
Collaborator
|
LGTM |
Bilb
requested changes
Mar 27, 2025
Bilb
reviewed
Mar 27, 2025
…pload step in release workflow
…hout an external script
we are using a wildcard so pattern is required
updated file permissions
Bilb
approved these changes
Mar 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked by: #95This PR adds support for arm64 builds for macOS! 🎉
Resolves:
#39
#574
#311
electron-builderand drops the fixed version requirement fordmg-buildersince the related bug has now been resolved.