Skip to content

feat: allow subset of ctx menu actions when searching #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Bilb merged 1 commit into from
Mar 16, 2025
Merged

feat: allow subset of ctx menu actions when searching #99

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 22 additions & 4 deletions ts/components/menu/ConversationListItemContextMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,6 @@ const ConversationListItemContextMenu = (props: PropsContextConversationItem) =>
const disabledLegacyGroup = useDisableLegacyGroupDeprecatedActions(convoIdFromContext);
const isPinned = useIsPinned(convoIdFromContext);

if (isSearching) {
return null;
}

if (disabledLegacyGroup) {
return (
<SessionContextMenuContainer>
Expand All @@ -67,6 +63,28 @@ const ConversationListItemContextMenu = (props: PropsContextConversationItem) =>
);
}

if (isSearching) {
// When we are searching, we can sometimes find conversations that should have a limited set of actions,
// so here we have a whitelist of what can be done.

return (
<SessionContextMenuContainer>
<Menu id={triggerId} animation={getMenuAnimation()}>
<DeleteDeprecatedLegacyGroupMenuItem />
<PinConversationMenuItem />
<BlockMenuItem />
<CopyCommunityUrlMenuItem convoId={convoIdFromContext} />
<CopyAccountIdMenuItem pubkey={convoIdFromContext} />
<DeleteMessagesMenuItem />
<DeletePrivateConversationMenuItem />
<LeaveCommunityMenuItem />
<LeaveGroupMenuItem />
<DeleteGroupMenuItem />
</Menu>
</SessionContextMenuContainer>
);
}

return (
<SessionContextMenuContainer>
<Menu id={triggerId} animation={getMenuAnimation()}>
Expand Down
Loading