Implement-get_ca_certs-for-macos #177
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
On Mac OS, the
load_default_certsSSLContextmethod does not load the system root certificate. In order for theget_ca_certsmethod to work properly on mac os, we need to override theload_defaults_certsmethod on Mac OS.Method
We extract the certificates using the Security Framework, with the
SecTrustCopyAnchorCertificatesfunction. We then load the certificates using theload_verify_locationSSLContextmethod which accepts DER-encoded byte-like certificates in thecadataargument.