Skip to content

Conversation

@supersergiy
Copy link
Collaborator

Integrating the basic version of scriber into corgie and mazepa.

Verified to produce correct results with NormalizationJob and AlignBlockJob.

MergeRender tasks shrunk to 2KB

To test: use mazepa -e git+https://github.com/supersergiy/scheduler.git@8905783b680cafcebfec52fec7f0e68e4be0e5fd#egg=mazepa`

@supersergiy supersergiy requested a review from nkemnitz April 19, 2021 18:44
Copy link
Contributor

@nkemnitz nkemnitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • objectscriber needs to be added to the requirements
  • This line in MiplessCloudVolume.__init__ is problematic:
    if 'info' in self.cv_params and overwrite:
    self.store_info()
    Only the scheduler should create/overwrite the info file - right now all workers will try to rewrite the info file simultaneously, which is causing e.g. GCS to panic with 429 errors.

Is there a good way to figure out if the job was initialized by the worker or the scheduler?

@nkemnitz
Copy link
Contributor

  • DownsamplingJob workers suddenly complained about the dst_layer (not specified) being readonly

@supersergiy
Copy link
Collaborator Author

Thanks for the feedback! I'll address these issues asap

@supersergiy
Copy link
Collaborator Author

supersergiy commented May 3, 2021

Added a global settings.py file which keeps track of whether the process is worker or not. Workers don't upload info.
Added objectscriber to setup.py.
Solved the downsample issues.
@nkemnitz

Copy link
Contributor

@nkemnitz nkemnitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one typo - see suggestion
Besides objectscriber, does this PR also require a minimal mazepa version? If so, that should be specified.

supersergiy and others added 2 commits May 3, 2021 10:59
Co-authored-by: Nico Kemnitz <nkemnitz@princeton.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants