-
Notifications
You must be signed in to change notification settings - Fork 3
Integrating Scriber into Corgie #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
nkemnitz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
objectscriberneeds to be added to the requirements- This line in
MiplessCloudVolume.__init__is problematic:Only the scheduler should create/overwrite the info file - right now all workers will try to rewrite the info file simultaneously, which is causing e.g. GCS to panic with 429 errors.corgie/corgie/mipless_cloudvolume.py
Lines 91 to 92 in d6a973a
if 'info' in self.cv_params and overwrite: self.store_info()
Is there a good way to figure out if the job was initialized by the worker or the scheduler?
|
|
Thanks for the feedback! I'll address these issues asap |
|
Added a global |
nkemnitz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one typo - see suggestion
Besides objectscriber, does this PR also require a minimal mazepa version? If so, that should be specified.
Co-authored-by: Nico Kemnitz <nkemnitz@princeton.edu>
Integrating the basic version of scriber into
corgieandmazepa.Verified to produce correct results with
NormalizationJobandAlignBlockJob.MergeRender tasks shrunk to 2KB
To test: use
mazepa-e git+https://github.com/supersergiy/scheduler.git@8905783b680cafcebfec52fec7f0e68e4be0e5fd#egg=mazepa`