ND, feature transform, tests, performance improvements#58
ND, feature transform, tests, performance improvements#58kevinjohncutler wants to merge 118 commits intoseung-lab:masterfrom
Conversation
|
Ok, I have completed my cleanup of the code and addressed all the above concerns and ideas. Ready for review! If everything else looks good, we can strip out the legacy comparisons as a final step. |
|
Thank you! I'll dig into the core logic some more. Thank you for all the work you've put into this PR so far! |
|
@william-silversmith I think I figured out a way to generalize to any L-norm. Interested in making that part of this PR? Might have to rebrand to "efficient distance transform" or "exact distance transform" haha |
|
That's a very interesting idea (it's discussed in the Felzenszwald and Huttenlocher paper I believe), but let's limit the scope of this PR, it's very complex already containing at least 4 different ideas and a full rewrite. Once it goes through, it can be built off of. Appreciate your enthusiasm! |
|
I happened to drum up an implementation of expand_labels with numba that beat the implementation we had in edt. However, I was able to learn from and surpass the numba implementation, which happened to give the main edt calls a speed boost as well (1.2x on average). |
|
Sorry for the delay! Will get to reviewing the core very soon. Just been busy. |
Summary
Testing
Notes