Skip to content
This repository was archived by the owner on Sep 25, 2025. It is now read-only.

fix incorrect timeout calculation#84

Open
bennettp123 wants to merge 3 commits intomainfrom
fix/incorrect-timeout-calculation
Open

fix incorrect timeout calculation#84
bennettp123 wants to merge 3 commits intomainfrom
fix/incorrect-timeout-calculation

Conversation

@bennettp123
Copy link
Member

@bennettp123 bennettp123 commented Jun 27, 2025

This PR fixes an error that causes the timeout to be 1/3 of the expected timeout.

Steps to reproduce:

new WaitForEcsDeployment(
  'deployment',
  {
    timeoutMs: 25 * 60 * 1000, // 25 minutes
    // ...
  }
)

Expected result:

  • timeout after 25 minutes

Actual result:

  • timeout after 8.3333 minutes

Related:

@changeset-bot
Copy link

changeset-bot bot commented Jun 27, 2025

🦋 Changeset detected

Latest commit: f596d1f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@wanews/pulumi-wait-for-ecs-deploy Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@bennettp123 bennettp123 force-pushed the fix/incorrect-timeout-calculation branch from 257853f to 67d5c17 Compare June 27, 2025 08:15
@xavierfolland
Copy link

This has been moved into the regular org we use.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants