Implement routing refactoring with review fixes for PR #17 by Copilot · Pull Request #18 · sf-kosen/homepage

Copilot · 2026-02-10T10:51:16Z

Implements the routing system refactoring proposed in PR #17, addressing all code review feedback. Converts hardcoded routes to configuration-based approach with metadata support and dynamic title management.

Changes

Type system (src/types/routes.ts): Route types with metadata (title, navLabel, visibleInNav, protected)
Route configuration (src/config/routes.tsx): Centralized nested route definitions with:
- flattenRoutes() recursively flattens nested structure
- joinPaths() handles path concatenation with edge cases
- routesByPath Map for O(1) lookups (built without intermediate arrays)
- DEFAULT_ROUTE constant eliminates hardcoded /events/lt-1 duplicates
MetaHandler (src/Components/handler/Metahandler.tsx): Updates document.title on route change using Map lookup with fallback
App component (src/App.tsx): Simplified to iterate over flatRoutes array
HTML title: Updated to "Web / 湘南藤沢高専"

Review fixes applied

Join route path corrected from / to /join (eliminated conflict)
flatRoutes computed at module level (prevents re-computation on render)
Consistent object syntax (removed JSON-style quotes)
Proper import type usage for ReactNode
Semicolons after type definitions per codebase convention

Example

const routes: Array<HasChildrenRoute> = [
  { path: "/join", element: <Join />, 
    meta: { title: "Join", visibleInNav: true } },
  { path: "events", element: <Navigate to={DEFAULT_ROUTE} replace />,
    children: [
      { path: "lt-1", element: <LT1 />, meta: { title: "LT1" } }
    ]
  }
];

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

vercel · 2026-02-10T10:51:22Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
homepage	Ready	Preview, Comment	Feb 10, 2026 10:59am

- Created src/types/routes.ts with proper type definitions (using semicolons and import type) - Created src/Components/handler/Metahandler.tsx for dynamic document title handling - Created src/config/routes.tsx to separate route configuration from App component - Refactored src/App.tsx to use dynamic route generation - Updated index.html title to "Web / 湘南藤沢高専" All review comments addressed: ✓ flatRoutes calculation moved outside component to avoid re-rendering ✓ Join route correctly uses /join path ✓ Consistent object key formatting (no quotes) ✓ Proper import type { ReactNode } usage ✓ Semicolons added after type definitions for consistency Co-authored-by: tanahiro2010 <129029050+tanahiro2010@users.noreply.github.com>

- Add comment explaining protected field in RouteMeta (reserved for future auth) - Extract hardcoded DEFAULT_ROUTE constant for consistency - Optimize MetaHandler to use Map for O(1) route lookup instead of O(n) array find Co-authored-by: tanahiro2010 <129029050+tanahiro2010@users.noreply.github.com>

- Use for-of loop instead of .map() to avoid intermediate array when creating routesByPath Map - Add DEFAULT_TITLE fallback in MetaHandler for routes without explicit titles Co-authored-by: tanahiro2010 <129029050+tanahiro2010@users.noreply.github.com>

- Handle empty string child path by returning parent or "/" for better robustness Co-authored-by: tanahiro2010 <129029050+tanahiro2010@users.noreply.github.com>

Copilot

Pull request overview

Refactors the app’s routing to be configuration-driven with typed route metadata, enabling centralized route definitions and dynamic document title updates based on the current route.

Changes:

Added typed route definitions with optional metadata (title, navLabel, visibleInNav, protected).
Introduced centralized nested route configuration with helpers to flatten routes and build a routesByPath lookup map.
Updated the app to render routes from the flattened configuration and added a MetaHandler to manage document.title; updated the base HTML title.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/types/routes.ts	Defines route and metadata types used by the new routing config.
src/config/routes.tsx	Central route configuration, route flattening, and O(1) path lookup map.
src/Components/handler/Metahandler.tsx	Updates `document.title` on navigation using the path lookup map.
src/App.tsx	Switches from hardcoded routes to iterating `flatRoutes` and mounts `MetaHandler`.
index.html	Updates the base document title string.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-10T11:26:19Z

src/Components/handler/Metahandler.tsx

+  useEffect(() => {
+    const match = routesByPath.get(pathname);
+    document.title = match?.meta?.title ?? DEFAULT_TITLE;
+  }, [pathname]);


useEffect uses routesByPath and DEFAULT_TITLE from outer scope but they are not included in the dependency array, which will trigger react-hooks/exhaustive-deps warnings and can lead to stale values if either ever changes. Include them in the deps array (or intentionally suppress the rule with a comment if you want to treat them as stable constants).

Suggested change

}, [pathname]);

}, [pathname, routesByPath, DEFAULT_TITLE]);

Copilot · 2026-02-10T11:26:20Z

src/App.tsx

+import MetaHandler from "./Components/handler/Metahandler";
+import { flatRoutes } from "./config/routes";


The file is named Metahandler.tsx while the exported component is MetaHandler and other components use PascalCase filenames (e.g. src/Components/ui/Button.tsx, src/Components/layout/Section.tsx). Consider renaming the file to MetaHandler.tsx and updating this import to avoid casing inconsistencies (and potential issues on case-sensitive filesystems).

Copilot · 2026-02-10T11:26:20Z

src/config/routes.tsx

+
+const isVotePageEnabled = import.meta.env.VITE_LT1_VOTE_ENABLED === "true";
+
+const DEFAULT_ROUTE = "/events/lt-1";


DEFAULT_ROUTE is defined here but /events/lt-1 is still hardcoded in other components (e.g. links in LT1Register/VotePresenter). Export DEFAULT_ROUTE (or another shared constant) so those callers can import it, reducing duplication and the risk of routes drifting out of sync if the default event route changes.

Suggested change

const DEFAULT_ROUTE = "/events/lt-1";

export const DEFAULT_ROUTE = "/events/lt-1";

Initial plan

4d33e8c

Copilot AI assigned Copilot and tanahiro2010 Feb 10, 2026

Copilot started work on behalf of tanahiro2010 February 10, 2026 10:51 View session

vercel bot deployed to Preview February 10, 2026 10:51 View deployment

vercel bot deployed to Preview February 10, 2026 10:55 View deployment

vercel bot deployed to Preview February 10, 2026 10:56 View deployment

vercel bot deployed to Preview February 10, 2026 10:57 View deployment

Add edge case handling for empty string paths in joinPaths

f5e2a39

- Handle empty string child path by returning parent or "/" for better robustness Co-authored-by: tanahiro2010 <129029050+tanahiro2010@users.noreply.github.com>

vercel bot deployed to Preview February 10, 2026 10:59 View deployment

Copilot AI changed the title ~~[WIP] Review code changes from pull request 17~~ Implement routing refactoring with review fixes for PR #17 Feb 10, 2026

Copilot AI requested a review from tanahiro2010 February 10, 2026 11:00

Copilot finished work on behalf of tanahiro2010 February 10, 2026 11:00

tanahiro2010 marked this pull request as ready for review February 10, 2026 11:22

Copilot AI review requested due to automatic review settings February 10, 2026 11:22

Copilot started reviewing on behalf of tanahiro2010 February 10, 2026 11:22 View session

Copilot AI reviewed Feb 10, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement routing refactoring with review fixes for PR #17#18

Implement routing refactoring with review fixes for PR #17#18
Copilot wants to merge 5 commits intomainfrom
copilot/review-code-changes

Copilot AI commented Feb 10, 2026 •

edited

Loading

Uh oh!

vercel bot commented Feb 10, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 10, 2026

Uh oh!

Copilot AI Feb 10, 2026

Uh oh!

Copilot AI Feb 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		import MetaHandler from "./Components/handler/Metahandler";
		import { flatRoutes } from "./config/routes";


		const isVotePageEnabled = import.meta.env.VITE_LT1_VOTE_ENABLED === "true";

		const DEFAULT_ROUTE = "/events/lt-1";

	const DEFAULT_ROUTE = "/events/lt-1";
	export const DEFAULT_ROUTE = "/events/lt-1";

Conversation

Copilot AI commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Review fixes applied

Example

Uh oh!

vercel bot commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Feb 10, 2026 •

edited

Loading

vercel bot commented Feb 10, 2026 •

edited

Loading