Fixes #1: Sidebar Style Inconsistent#11
Open
tbduong wants to merge 4 commits intosf-wdi-30:masterfrom
Open
Conversation
Author
|
-Condense style changes: sidebar Archive and List style fixes changes occur in user-style.css. |
| } | ||
|
|
||
| .sidebar_title { | ||
| font-family: monospace; |
There was a problem hiding this comment.
This PR introduces redundant CSS rules for styling the sidebar. Can we use existing rules?
melicarls
added
G2M - Great job!
Squash your commits (too messy!)
and removed
NOT YET APPROVED
unnecessary file changes
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #1: Sidebar style inconsistencies found within archives_sidebar/content view:
Found that class names were entered incorrectly (e.g: "sidebar_title" should be "sidebar-title"). Issue resolved and classes renamed correctly. Sidebar Style corrected.