Fix Issue #1 Inconsistent Sidebar Styling#28
Open
im-mattbrown wants to merge 1 commit intosf-wdi-30:masterfrom
im-mattbrown:fix_sidebar
Open
Fix Issue #1 Inconsistent Sidebar Styling#28im-mattbrown wants to merge 1 commit intosf-wdi-30:masterfrom im-mattbrown:fix_sidebar
im-mattbrown wants to merge 1 commit intosf-wdi-30:masterfrom
im-mattbrown:fix_sidebar
Conversation
nathanallen
added
G2M - Great job!
and removed
NOT YET APPROVED
Squash your commits (too messy!)
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes Issue #1 the inconsistent sidebar styling where the class name for div and h3 in lib/archives_sidebar/app/views/archives_sidebar/_content.html.erb.
There is no css class for "sidebar_title" or "sidebar_body" and they should have been class "sidebar-body" instead.