rsa,ec,dsa: improve coverage of de-/serialisation methods #2446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
huwcbjones
commented
Aug 21, 2025
huwcbjones
commented
- Serialise the test key(s) in several different formats
- Compare serialisation output directly against known good (to prevent regressions)
- Rename the test keys to have a consistent naming scheme
- Add more deserialisation tests covering different input formats
huwcbjones
force-pushed
the
huw/improve-serde-tests
branch
2 times, most recently
from
63ac606 to
738d387
Compare
* Serialise the test key in several different formats * Compare serialisation output directly against known good (to prevent regressions) * Rename the test keys to have a consistent naming scheme * Add more deserialisation tests covering different input formats
huwcbjones
force-pushed
the
huw/improve-serde-tests
branch
from
738d387 to
2105f91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.