ML-KEM/ML-DSA part 1: openssl-sys changes #2450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Splitting up sfackler#2405 into a few parts as suggest by @alex. This adds the non-param-builder openssl-sys changes. Co-authored-by: Justus Winter <[email protected]>
swenson
force-pushed
the
pqc-openssl-sys
branch
from
be9ff22 to
42ad140
Compare
alex
reviewed
Aug 29, 2025
Comment on lines
+180
to
+185
| if version >= 0x3_04_00_00_0 { | ||
| println!("cargo:rustc-cfg=ossl340"); | ||
| } | ||
| if version >= 0x3_05_00_00_0 { | ||
| println!("cargo:rustc-cfg=ossl350"); | ||
| } |
There was a problem hiding this comment.
You also need these in openssl-sys/build I believe
There was a problem hiding this comment.
Looks like 340 is already there; adding 350
alex
approved these changes
Aug 29, 2025
|
thanks for looking at this |
|
Thanks @alex. I'll try to do the other parts sometime soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting up #2405 into a few parts as suggest by @alex.
This adds the non-param-builder openssl-sys changes.