Update hub.py to be compatible with PyModbus >=3.10 and HA 2025.9#362
Merged
sfstar merged 1 commit intosfstar:mainfrom Aug 31, 2025
Merged
Update hub.py to be compatible with PyModbus >=3.10 and HA 2025.9#362sfstar merged 1 commit intosfstar:mainfrom
sfstar merged 1 commit intosfstar:mainfrom
Conversation
Attempt to make victron integration compatible with pymodbus API 3.10.0 and greater "Change slave to device_id and slave= to device_id=. (#2600)" https://pymodbus.readthedocs.io/en/latest/source/api_changes.html
jacauc
changed the title
sfstar
added
the
bugfix
Owner
|
Thank you for opening this pr, |
sfstar
added a commit
that referenced
this pull request
Aug 31, 2025
…ers_that_were_added_to_venus_since_integration_inception Revert "Feature/add all registers that were added to venus since integration inception" in order to allow #362 to be merged as an hotfix
sfstar
approved these changes
Aug 31, 2025
Owner
sfstar
left a comment
sfstar
left a comment
There was a problem hiding this comment.
LGTM, Didn't test it with the beta release as of yet but it matches the changelog of pymodbus pr #2600 https://pymodbus.readthedocs.io/en/latest/source/changelog.html#version-3-10-0 and home-assistant/core@7572b2a with the pr of the upcoming 2025.9 beta release
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to make victron integration compatible with pymodbus API 3.10.0 and greater
"Change slave to device_id and slave= to device_id=. (#2600)"
https://pymodbus.readthedocs.io/en/latest/source/api_changes.html
Breaking change
Proposed change
Type of change
Additional information
Checklist
ruff format custom_components/victron)