Ensure entity_id is lowercase for all slaves#408
Conversation
Refactor entity_id assignment to ensure lowercase format for all cases. Required for HA 2026.2.0
|
Can add labels, sorry. |
|
Also fixes #405 |
mr-p666
left a comment
There was a problem hiding this comment.
Tested in my environment.
Works again! (y)
mr-p666
left a comment
There was a problem hiding this comment.
And as @ondrom111 already mentioned, these files also need to be updated.
binary_sensor.patch
button.patch
number.patch
select.patch
switch.patch
|
Isbthere a Fork wäre the Patches are applied? So i can Update without manually changing Files? I am remote currentpy and changing Files in the cell Phone ist no fun |
Did you make these changes, or you want me to add another PR? |
|
@sfstar would be great if you could accept the pull request and publish a new version so that we don't have to manually edit files. Thanks! |
Ensure entity_id is in lowercase for consistency.
Ensure entity_id is consistently lowercased for all cases.
Ensure entity_id is in lowercase for consistency.
Ensure entity_id is in lowercase for consistency.
Convert entity_id to lowercase for consistency.
|
The remaining files have been updated with lowercase. Ive included #400 as well in this (typo) |
|
Can you create a Release in your Fork, so i can use IT untlil sfstar creatrs a New Release? |
Ive created one but im unsure it will work as you usually need to do a heap of stuff to make HACS acknowledge it as a new integration, which takes weeks. But if you can get it to work, then coolio! |
Thank you, but you are right, it did not work.. i wonder why, because i did this before...... |
|
Thanks for submitting this PR. Will review and release it this afternoon |
sfstar
left a comment
There was a problem hiding this comment.
LGTM, will test migration of historical data and provide migration function and then release this on 0.7.x release (also containing new registers).
|
@sfstar that'd be great. Looking forward to 0.7! |
Refactor entity_id assignment to ensure lowercase format for all cases. Required for HA 2026.2.0
Breaking change
HA 2026.2.0 requires all entities to be lowercase. Some entities from Victron contain capitals, such as L1, L2 etc.
We now convert these to lower case.
Has been tested to not impact existing integrations, automations, graphs etc.
Old Entity ID: sensor.victron_system_consumption_L1
New Entity ID: sensor.victron_system_consumption_l1
Proposed change
Update sensor.py to include ".lower()" at the end of the Sensor naming convention on line 161 and 164. Suggested update by @ondrom111 on case #407.
Type of change
Additional information
Checklist
ruff format custom_components/victron)