Skip to content

Fix recorder crash and noisy logs for Victron integration #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gronke wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −2
Open

Fix recorder crash and noisy logs for Victron integration #424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion custom_components/victron/const.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -725,7 +725,7 @@ class microgrid_error(Enum):
230, UINT16, 1, entityType=ButtonWriteType()
),
"vebus_microgrid_error": RegisterInfo(
231, UINT16, TextReadEntityType(microgrid_error)
231, UINT16, entityType=TextReadEntityType(microgrid_error)
),
}

Expand Down
5 changes: 4 additions & 1 deletion custom_components/victron/sensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
ReadEntityType,
TextReadEntityType,
register_info_dict,
UINT16_MAX,
)
from .coordinator import victronEnergyDeviceUpdateCoordinator

Expand Down Expand Up @@ -181,7 +182,9 @@ def _handle_coordinator_update(self) -> None:
if self.entity_type is not None and isinstance(
self.entity_type, TextReadEntityType
):
if data in {item.value for item in self.entity_type.decodeEnum}:
if data in (UINT16_MAX, float(UINT16_MAX)):
self._attr_native_value = None
elif data in {item.value for item in self.entity_type.decodeEnum}:
self._attr_native_value = self.entity_type.decodeEnum(
data
).name.split("_DUPLICATE")[0]
Expand Down