Skip to content

Conversation

tomwhite
Copy link
Contributor

@tomwhite tomwhite commented Dec 2, 2024

I noticed that I didn't set the dimension separator when doing #290.

I also noticed that contig_id, contig_length, filter_id, and sample_id don't have a dimension separator set - which OK as they are one-dimensional - but slightly inconsistent as there are other fields that are one-dimensional that do have it set, like variant_id. Should we just set it everywhere?

@tomwhite tomwhite added the bug Something isn't working label Dec 2, 2024
@coveralls
Copy link
Collaborator

coveralls commented Dec 2, 2024

Coverage Status

coverage: 98.91%. remained the same
when pulling ae1a046 on tomwhite:dim-separator-fix
into b9340c4 on sgkit-dev:main.

@jeromekelleher jeromekelleher merged commit 0ef5623 into sgkit-dev:main Dec 3, 2024
14 checks passed
@jeromekelleher
Copy link
Contributor

Should we just set it everywhere?

I don't really mind. I set the dimension separator to / as this seemed the more scalable option for the large 2D fields and followed the defaults in v3 (making upgrades to format=3 stores later more straightforward, potentially).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants