Use specified dimension separator for region index #293
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that I didn't set the dimension separator when doing #290.
I also noticed that
contig_id
,contig_length
,filter_id
, andsample_id
don't have a dimension separator set - which OK as they are one-dimensional - but slightly inconsistent as there are other fields that are one-dimensional that do have it set, likevariant_id
. Should we just set it everywhere?