Merge contig headers across VCFs #335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromekelleher
force-pushed
the
merge-header-contigs
branch
3 times, most recently
from
c2ef14a to
744da80
Compare
|
This is ready for review. The merge logic is fairly simple and hopefully obvious. Trying not to overthink the cases where we might fail or not fail on different contig definitions, and just doing a hard equality check. If this is a problem someone will report it. |
benjeffery
approved these changes
Mar 19, 2025
jeromekelleher
force-pushed
the
merge-header-contigs
branch
from
744da80 to
f22234f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #334