Add defaults to schema #357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bio2zarr/vcz.py
Outdated
| self.format_version = format_version | ||
| self.fields = fields | ||
| defaults = defaults if defaults is not None else {} | ||
| if "compressor" not in defaults or defaults["compressor"] is None: |
There was a problem hiding this comment.
Suggested change
| if "compressor" not in defaults or defaults["compressor"] is None: | |
| if defaults.get("compressor", None) is None: |
shorter, less duplication of the key text
benjeffery
force-pushed
the
schema-redundancy
branch
from
21d3c67 to
77dfbc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
defaultssection to the schema. Also move the resposibilty for specific compressor settings to thegenerate_schemamethods.Part of #351