VCF field conversion bugs #358
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #353 and #355.
However, there is another failing case (like #353), shown by the
INFO/HWE_EUR_unrel
field in 1kg_2020_chr20_annotations.bcf, which has Number=A, but max_number=0. To fix that, requires finding the actual size of A (alt alleles) for the whole dataset.There's a comment about this:
bio2zarr/bio2zarr/vcz.py
Lines 143 to 144 in 17db733
@jeromekelleher have you thought about how to implement this?