Skip to content

Conversation

tomwhite
Copy link
Collaborator

@tomwhite tomwhite commented Jun 25, 2024

Not expected to pass - mainly to record failing tests for #1234

This is passing now that scikit-allel is works with NumPy 2.

  • Fixes Run tests against NumPy 2 #1234
  • Tests added
  • User visible changes (including notable bug fixes) are documented in changelog.rst
  • New functions are listed in api.rst

@tomwhite tomwhite force-pushed the numpy-2 branch 2 times, most recently from d709210 to da74f47 Compare September 2, 2024 09:24
@tomwhite tomwhite marked this pull request as ready for review September 2, 2024 09:59
@tomwhite
Copy link
Collaborator Author

tomwhite commented Sep 2, 2024

I've added a separate GitHub Actions workflow to run using NumPy 2 so we can test against both NumPy versions. NumPy 1 is still the default.

@tomwhite tomwhite merged commit 03daf6b into sgkit-dev:main Sep 2, 2024
8 checks passed
@tomwhite tomwhite deleted the numpy-2 branch September 2, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run tests against NumPy 2
2 participants