Run tests using Zarr Python v3 #1277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomwhite
commented
Nov 4, 2024
|
|
||
|
|
||
| def save_dataset( | ||
| ds: Dataset, | ||
| store: Union[PathType, MutableMapping[str, bytes]], | ||
| storage_options: Optional[Dict[str, str]] = None, | ||
| auto_rechunk: Optional[bool] = None, | ||
| zarr_format: int = 2, |
There was a problem hiding this comment.
Note that we're still using version 2 of the Zarr file format.
tomwhite
force-pushed
the
zarr-python-v3
branch
from
f2983f3 to
dbc926f
Compare
tomwhite
force-pushed
the
zarr-python-v3
branch
from
dbc926f to
c4f728f
Compare
tomwhite
force-pushed
the
zarr-python-v3
branch
from
c4f728f to
88cde21
Compare
|
This was more straightforward now that the VCF code has been moved to bio2zarr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.