Backward and forward-compatible changes to support zarr-python v3 #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomwhite
force-pushed
the
zarr-python-v3-compatibility
branch
from
db0af0c to
9a78fbf
Compare
jeromekelleher
approved these changes
Nov 29, 2024
Yes - I think I may do the uncontroversial changes for bio2zarr separately too, as doing the whole thing in one go is proving tricky... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #98
I haven't included tests that run on zarr-python v3, as that requires sgkit-dev/bio2zarr#288 which isn't ready yet. But I managed to run the tests locally under v3 with that change, and they all passed.
This is compatible with zarr-python v2, so it could be merged soon (before the bio2zarr change is done). (But no rush as #105 needs sorting out first.)