Skip to content

Conversation

tomwhite
Copy link
Contributor

Fixes sgkit-dev/bio2zarr#184

This needs sgkit-dev/bio2zarr#352 (from bio2zarr). This is not working yet as it exposes some corner cases in the VCF conversion that may be bugs. I'll open issues for these in bio2zarr.

@jeromekelleher
Copy link
Contributor

This would be a great step forward!

I wonder if we should try and get the rest of the header fields in to Zarr first in bio2zarr, so that we can more-or-less round-trip?

@tomwhite
Copy link
Contributor Author

I wonder if we should try and get the rest of the header fields in to Zarr first in bio2zarr, so that we can more-or-less round-trip?

We don't need to tie them together - would be OK to do them separately I think.

@jeromekelleher
Copy link
Contributor

Looks like you've dug out enough bugs to keep us going for a while in any case!

@tomwhite
Copy link
Contributor Author

All tests pass locally with the latest changes from sgkit-dev/bio2zarr#360

@tomwhite tomwhite marked this pull request as ready for review May 6, 2025 08:44
@tomwhite
Copy link
Contributor Author

tomwhite commented May 6, 2025

This can go in once there is a new release of bio2zarr.

@tomwhite tomwhite linked an issue May 7, 2025 that may be closed by this pull request
@tomwhite
Copy link
Contributor Author

Superceded by #208

@tomwhite tomwhite closed this May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "original_header" from write_vcf and improve test coverage
2 participants